https://bugzilla.redhat.com/show_bug.cgi?id=1677989 --- Comment #12 from Petr Menšík <pemensik@xxxxxxxxxx> --- pkgconfig file is great, but please move creation of it into %prep section. Just use cat > vcglib.pc ... in %prep, then in %install just: install vcglib.pc %{buildroot}%{_datarootdir}/pkgconfig/vcglib.pc Please add "Requires: eigen3" to vcglib.pc You do not have to manually install README file. Just use in %files: %doc README.md It would install all such files from source directory for you. I think if you want to correct mode of source files, that should be done also in %prep. Might help: find -name '*.h' -exec chmod a-x '{}' ';' find -name '*.cpp' -exec chmod a-x '{}' ';' Then in install section, just copy vcg subdirectory: cp -a vcg %{buildroot}%{_includedir}/%{name} If it requires just vcg subdirectory indeed, maybe include path might be omitted and install it just directly into /usr/include/vcg. Then pkgconfig would not be required for building, it would work automatically. I think that would be best option here. Upstream should be asked to correct it in next release, please fill issue on their github. Also, since this library is header-only, it has to provide vcglib-static in devel subpackage [1]. In devel subpackage, only headers required to build application should be used. It seems to me vcg subdirectory is the only one belonging there, maybe also img. Please do NOT install eigenlib at all. Apps should be packaged in separate utils subpackage. If you insist they are not to be compiled and packaged, just do not include their headers and other files. Removing just *.cpp files is not enough. Either compile them and install compiled binaries or do not install it at all. They would be already part of source package, there is no point installing all sources as part of normal package. Headers in devel package used by other packages are exception to this. Binary rpm should contain prebuilt executables and scripts that do not require compilation, or data. 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries I think at least some of apps should be compiled and installed, but would accept if you want this for wdune dependency only. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
