https://bugzilla.redhat.com/show_bug.cgi?id=1673125 --- Comment #9 from Troy Dawson <tdawson@xxxxxxxxxx> --- Spec URL: https://tdawson.fedorapeople.org/gateway/mozilla-iot-gateway.spec SRPM URL: https://tdawson.fedorapeople.org/gateway/mozilla-iot-gateway-0.7.0-2.fc30.src.rpm I cleaned up more empty files, directories, and permissions. When doing a fedora-review you will see the following, but they need to be in there - hidden-file-or-dir that ends with .bin -- This is a nodejs thing, and they need to be there. - zero-length file that is in a test directory -- These need to be there for tests - zero-length file that is not in a test directory -- I have trimmed out all the zero length files that are not being called by something. -- The ones that are left appear that things would break if they are removed. - useless-provides bundled(...) -- I have a "Provides: bundled(<name>) = <version>" for each bundled nodejs module. For some, there is more than one version of a nodejs module. fedora-review strips the version off of each of these, and then complains that there is more than one entry for <name>. -- I can either not have a version on each entry, or I can make it so fedora-review doesn't complain. I was told to keep the version on each entry, and so your fedora-review will have these errors. I believe this package is ready. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
