Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: OpenSER - Open Source SIP Server https://bugzilla.redhat.com/show_bug.cgi?id=254142 ------- Additional Comments From ondrejj@xxxxxxxxxx 2007-09-24 12:31 EST ------- "which" does not needed to be in buildrequires, see: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions All documentation files need to be in UTF-8. More updates from changelog: - added reload section to init script this is needed by rpmlint - init script specified with initrddir macro http://fedoraproject.org/wiki/Packaging/RPMMacros - documentation converted to UTF-8 guidelines: - MUST: All filenames in rpm packages must be valid UTF-8. - added doc macro for documentation - documentation moved do proper place (/usr/share/doc/NAME-VERSION/) - unixodbc subpackage summary update (word order changed to start with upper case letter) http://www.salstar.sk/pub/fedora/SRPMS/7/openser-1.2.2-9.fc7.src.rpm I see only one thing left. Perl subpackage need to be in perl5/site... directory or not? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review