https://bugzilla.redhat.com/show_bug.cgi?id=1658153 --- Comment #45 from Petr Menšík <pemensik@xxxxxxxxxx> --- Usually subpackage sections of %package docs and %description docs follows after main %description, before %prep section. %files docs should follow after %files. Best practice for defining %global macros is to place them before all tags like Summary. %global extraver pl1414 %global upstream_version %{version}%{?extraver} ... Version: 0.99 Release: 2%{?extraver}%{?dist} ... Source: ftp://ftp.ourproject.org/pub/wdune/wdune-%{upstream_version}.tar.bz2 I would recommend also using macro in --with-about="wdune-%{upstream_version}" in %configure -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
