https://bugzilla.redhat.com/show_bug.cgi?id=1677989 --- Comment #9 from Petr Menšík <pemensik@xxxxxxxxxx> --- comment #1 states main package vcglib should be empty. It does not mean you have to remove examples from tarball. I think on contrary, it should not be deleted from source archive. We expect you would release one source archive for all distributions, always the same. It can be chosen in spec file, which part would be packaged and which should not be packaged. If you have to delete some parts, delete them in build process only. Deleted from sources should be just parts with incompatible license, nothing else. I am not sure about that. Main package usually contains only compiled library, check [1] for information. However, this library does not compile any shared library that can be reused. That might be fixed later, I think it does not work as library now but should. Instead, examples could have subpackage examples, with more runtime dependencies on them, especially is they are visually atractive and not simple to compile yourself. Ok, proposal is this. Includes would not contain eigenlib, it has its own project. Because vcglib as its own project on github [2], it definitely requires its own package and must NOT be part of wdune package. Ok, examples are not ready to use system-wide eigen3. But here we can reuse pkgconfig as well [3]. Just append to all used .pro files: cat > fedora.unix << QMAKE unix { CONFIG += link_pkgconfig PKGCONFIG += eigen3 } QMAKE find -name '*.pro' | while read P; do cat fedora.unix >> "$P"; done Then tools can be built. It seems they are not only samples, but also useful tools. They should be packed definitely. utils subpackage could be used for them, with all dependencies required to install them. I think it is strange there is no script to build all those tools in single command, it should be proposed to the project. It can be solved in spec file until that happens. Generated makefiles have no working install target unfortunately. I think such modifications should be recommended to the project in general, not just for Fedora. 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_libraries_and_applications 2. https://github.com/cnr-isti-vclab/vcglib 3. http://qt.shoutwiki.com/wiki/Using_pkg-config_with_qmake -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
