https://bugzilla.redhat.com/show_bug.cgi?id=1686506 --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to Lubomir Rintel from comment #2) > 1.) Why do you call the package lowercase "wireguard"? Upstream seems to > call the thing "WireGuard" >In Fedora packaging, the maintainer uses their best judgement when considering how to name the package. While case sensitivity is not a mandatory requirement, case SHOULD only be used where necessary. Keep in mind to respect the wishes of the upstream maintainers. If they refer to their application as "ORBit", you SHOULD use "ORBit" as the package name, and not "orbit". However, if they do not express any preference of case, you SHOULD default to lowercase naming. https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_case_sensitivity In any all the other distros use lowercase. > > 2.) What's the use of this in Fedora? > > > Provides: %{name}-kmod-common = %{version} > > %if 0%{?fedora} || 0%{?rhel} > 7 > > Suggests: %{name}-kmod >= %{version} > > %endif > > The Fedora kernel-core package seems to provide "kmod(<module>.ko)" for the > modules it ships. I guess that "kmod(wireguard.ko)" is what we should depend > on? Though I suppose only a weak dependency would do until the kernel > actually ships the module. For now it' for compatibility with the module from RPMFusion. Once the module is in mainline, it would be removed. Apparently this won't happen until at least 5.2. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
