https://bugzilla.redhat.com/show_bug.cgi?id=1686210 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 FIX: Please update URL and source0 to the new location: URL: https://metacpan.org/release/JSON-Validator Source0: https://cpan.metacpan.org/authors/id/J/JH/JHTHORSEN/JSON-Validator-%{version}.tar.gz All tests passed BuildRequires are ok $ rpm -qp --requires perl-JSON-Validator-3.06-1.fc30.noarch.rpm | sort | uniq -c 1 perl(B) 1 perl(base) 1 perl(Carp) 1 perl(constant) 1 perl(Exporter) 1 perl(JSON::Validator) 1 perl(JSON::Validator::Error) 1 perl(JSON::Validator::Formats) 1 perl(JSON::Validator::Joi) 1 perl(JSON::Validator::Ref) 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(Mojo::Base) 1 perl(Mojo::File) 1 perl(Mojo::JSON) 1 perl(Mojo::JSON::Pointer) 1 perl(Mojolicious) >= 7.28 1 perl(Mojo::Loader) 1 perl(Mojo::URL) 1 perl(Mojo::Util) 1 perl(overload) 1 perl(Scalar::Util) 1 perl(Tie::Hash) 1 perl(Tie::StdHash) 1 perl(Time::Local) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 All mandatory run-requires are listed. TODO: Please consider adding following optional dependencies as Suggests: YAML::XS 0.67 Term::ANSIColor Mojo::UserAgent Data::Validate::Domain Data::Validate::IP Net::IDN::Encode $ rpm -qp --provides perl-JSON-Validator-3.06-1.fc30.noarch.rpm | sort | uniq -c 1 perl(JSON::Validator) = 3.06 1 perl-JSON-Validator = 3.06-1.fc30 1 perl(JSON::Validator::Error) 1 perl(JSON::Validator::Formats) 1 perl(JSON::Validator::Joi) 1 perl(JSON::Validator::Ref) Binary provides are Ok. $ rpmlint ./perl-JSON-Validator* perl-JSON-Validator.noarch: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally perl-JSON-Validator.src: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok Please correct all 'FIX' issues and consider fixing 'TODO' items. Otherwise, the package looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
