https://bugzilla.redhat.com/show_bug.cgi?id=1686022 --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- > esp. once the kernel parts hit mainline kernel Do you know when is it supposed to happen? This package by itself is useless without the kernel module, isn't it? I would like to comaintain it at least if you plan to package it here. - Regarding the Review, you're missing the SystemD macros. %{?systemd_requires} BuildRequires: systemd-rpm-macros […] %post %systemd_post wg-quick@.service %preun %systemd_preun wg-quick@.service %postun %systemd_postun_with_restart wg-quick@.service - Add the examples to the %doc. (remove the .gitignore files there) - Use %set_build_flags to use all the default flags. - make %{?_smp_mflags} → %make_build - Use standard perms for /etc/wireguard instead of 0700 in the Makefile I don't know how to coordinate between RPMFusion and Fedora. On what branches do you want to package it? Would you be okay to add Release: 2%{?dist} to supersede the RPMFusion package? Would you add: Provides: %{name}-kmod-common = %{version} The problem is I need to sync the kmod package to the tools package and if we are handling this separately, it's gonna be problematic. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
