[Bug 1659556] Review Request: cockpit-composer - Composer GUI for use with Cockpit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1659556



--- Comment #13 from Martin Pitt <mpitt@xxxxxxxxxx> ---
Thanks Robert for the detailled review!

> - Use "cp -a" or "install -p" to keep file timestamps

Done in https://github.com/weldr/welder-web/pull/587

> - Don't mix tabs and spaces: tabs on line 2 and 3 but not afterwards

This needs to be fixed in our release machinery:
https://github.com/cockpit-project/cockpituous/pull/245

We'll make a new release soon after this lands.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux