https://bugzilla.redhat.com/show_bug.cgi?id=1677989 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@xxxxxxxxxx --- Comment #3 from Petr Menšík <pemensik@xxxxxxxxxx> --- Whatever test case you have, try to make it working with latest eigen3 headers provided by Fedora. That is requirement, it cannot be accepted without it. I would expect from the library to not prefix includes to its own libraries. Just remove eigenlib/ prefix from includes. Change #include <eigenlib/Eigen/Core> to #include <Eigen/Core> etc. Rely on compiler include paths configured when your library is used. It would be nice if you provided pkg-config file that depends on eigen3 library, but it is not required. Please do not use relative include paths like "../../eigenlib/Eigen/LU". Users of this package should use CPPFLAGS=`pkg-config --cflags eigen3` when including your headers. If they do, includes will work as expected and will reuse eigen3 headers from system. It has to live with its dependencies. If some structures were changed, adapt your code to match latest. Can you provide any example how you want users to use your package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
