https://bugzilla.redhat.com/show_bug.cgi?id=1685022 --- Comment #2 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #1) > - make %{?_smp_mflags} → %make_build > > - make install DESTDIR=%{buildroot} → %make_install I know these macros exist. I find them to be obfuscating and confusing and not at all helpful or clarifying. So not using them was a conscious decision on my part. For me they make the specfile harder to read. > - The libraries should be versioned: > > %{_libdir}/libHepMC3.so > > %{_libdir}/libHepMC3search.so I contacted uppstream and they added a soname, I have added a patch with this change taken from the upstream git in this updated version: Spec URL: http://www.grid.tsl.uu.se/review/HepMC3.spec SRPM URL: http://www.grid.tsl.uu.se/review/HepMC3-3.1.0-2.fc29.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
