Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wqy-unibit-fonts - a dual-width bitmap font for maximum unicode coverage https://bugzilla.redhat.com/show_bug.cgi?id=285561 ------- Additional Comments From petersen@xxxxxxxxxx 2007-09-24 04:58 EST ------- Ok, thanks, that is all ok. Sorry to keep you waiting so long. Below is my review. Good: + rpmlint is ok wqy-unibit-fonts.noarch: W: symlink-should-be-relative /etc/X11/fontpath.d/wqy-unibit-fonts /usr/share/fonts/wenquanyi/wqy-unibit (this can be waived or you can make it relative by prepending "../.." if you wish. + naming is based on upstream name + meets packaging guidelines + license is gplv2 and included + spec file is clear + source is pristine 751dacd1326cd49b44486b45c592cfa6 wqy-unibit-bdf-1.1.0-1.tar.gz + noarch package builds correctly + buildreqs listed + filelist ok Except the following, all must items are satisfied AFAICS. Needs attention: - both wqy-bitmap-fonts and this package own /usr/share/fonts/wenquanyi Personally I don't feel it is a blocker, but it is against the packaging guidelines: you should probably consider just using /usr/share/fonts/wenquanyi-unibit for this package and similarly for the other package. - Do you think there will be a wqy-unibit-ttf say one day? (just worrying if the name were to be too general) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review