[Bug 1684908] Review Request: golang-github-philhofer-fwd - Buffered Reader/Writer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1684908



--- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
1. The -devel package owns /usr/share/gocode/src/github.com, but not
   /usr/share/gocode/src.  That directory is owned by the golang package, but
   the -devel package does not Require golang.  The result is that someone can
   install the -devel package alone and end up with an unowned directory.

2. On a related note, the golang package also owns
   /usr/share/gocode/src/github.com, so if this package should Require golang,
   then it should not own that directory.

I can't do much about that, it is automated by the macros. The Golang package
owns the major distributor directories like github.com or gopk.in, but for the
other ones, we are owning them directly in the -devel subpackages. Hence the
coownership. This isn't a problem per se as the removal of the github directory
will happen when all packages owning it are removed.


3. Should the .goipath file be in the package?  (I know nothing about Go
   packaging, so pardon me if this is a stupid question.)

Yes that is normal.


4. Should LICENSE.md and README.md be in
   /usr/share/gocode/src/github.com/philhofer/fwd when they also appear in
   %license and %doc?

Again it's the macro which picks up all *.md files as part of the file to be
installed. I dont know the rationales for this, I'll ask the macro writer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux