https://bugzilla.redhat.com/show_bug.cgi?id=1658153 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #31 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Split this on multiple lines with \ %configure --with-about="wdune-0.99rc1352" --with-optimization --without-devil --with-helpurl="/usr/share/doc/wdune-docs/docs/" --with-protobaseurl="/usr/share/doc/wdune-docs/docs" --with-checkincommand="ci" --with-imageeditor="kolourpaint" --with-imageeditor4kids="kolourpaint" --with-soundeditor=audacity desktop-file-install --add-category="Graphics" --delete-original --dir=$RPM_BUILD_ROOT/%{_datadir}/applications $RPM_BUILD_ROOT/%{_datadir}/applications/dune.desktop - As said before a Recommends: would be better Requires: kolourpaint - /usr/share/doc → %{_docdir} - Put this in a more "normal" order in the SPEC, %changelog should be last %package docs Summary: Documentation for white_dune %description docs Documentation for white_dune […] %files docs %doc README.txt docs - The Versioning scheme is a bit dubious. "Unsortable versions When upstream uses a versioning scheme that does not sort properly, first see if there is any portion which can be removed from the right side of the version string such that the remainder is sortable. This is often possible if upstream uses a sequence like ("1.2pre1", "1.2pre1", "1.2final"). If so, use the removed portion as <extraver> above, and the remainder as the package version. If this splitting leaves a leading or trailing period in either value, remove it." The rcXXXX or plXXXX doesn't make it sortable I think. I would move rc1352 to extraver. And use Release: 2.%{extraver}%{?dist}. Then you bump the first Release number with each new extraver to have a sortable version scheme. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
