https://bugzilla.redhat.com/show_bug.cgi?id=1684719 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - You need to specify if 0%{?rhel}, otherwise it will evaluate as 0 and thus true on non-RHEL system: %if 0%{?rhel} <= 7 → %if 0%{?rhel} && 0%{?rhel} <= 7 - You could use bcond_with/bcond_without here (http://rpm.org/user_doc/conditional_builds.html): %if 0%{?fedora} >= 17 || 0%{?rhel} >= 7 %global with_systemd 1 %else %global with_systemd 0 %endif - make %{?_smp_mflags} → %make_build - make install DESTDIR=%{buildroot} → %make_install - Don't use these macros which don't bring anything more: %{__mkdir_p} → mkdir -p %{__install} → install %{__mv} → mv - Use install -p to keep timestamps - Use the needed Requires for systemd macros: BuildRequires: systemd → BuildRequires: systemd-rpm-macros %{?systemd_requires} The rest looks ok but I haven't run fedora-review yet, I'll wait for an update of the SPEC to address the aformentioned issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
