https://bugzilla.redhat.com/show_bug.cgi?id=1684524 --- Comment #3 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- (In reply to Jan Pazdziora from comment #2) > (In reply to Stephen Gallagher from comment #1) > > tl;dr: Minor issues, see the "Issues" section below. > > > > > > Package Review > > ============== > > > > Legend: > > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > [ ] = Manual review needed > > > > > > Issues: > > ======= > > - The package has `Requires: fedora-release-common` which means that it > > cannot be installed on a Fedora Remix. This should be > > `Requires: system-release` > > The primary reason for the Requires: fedora-release-common is to pull > in a package which owns /etc/swid, to which we put the swidq.conf config > file. > Currently, > > # rpm -qf /etc/swid > fedora-release-common-30-0.24.noarch > > How does the same work on Fedora Remix? A Fedora Remix is required to reimplement anything provided by the fedora-release package in a way that is applicable to their remix. That's why I recommended that you should move your dependency to the `system-release` virtual Provides. Also, you really don't want to be directly depending on fedora-release-common in any case; it's an implementation detail of the fedora-release-FOO packages. It's not really intended to be depended on by itself. Stephen Tweedie suggested elsewhere that this might also be a soft dependency. If this package doesn't strictly need this for any reason other than the directory, I'd say that the better approach would just be to drop the dependency entirely and just co-own the /etc/swid directory. This is an acceptable packaging practice (for example, it's used commonly for packages that drop bash-completion content into those paths but don't want to force bash-completion to be installed). In this case, it's kind of a moot point, because it's impossible for any Fedora system to exist that doesn't have a system-release package installed. > > > - The dnf-plugin-swidtags subpackage has an unversioned `Requires: > > swid-tools` > > This should be `Requires: swid-tools = %{version}-%{release}` to ensure > > they > > are always updated together. > > - Use %global upstream_name, not %define > > Will fix these, thanks. Any time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
