Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ladspa-mcp-plugins - A set of audio plugins for LADSPA https://bugzilla.redhat.com/show_bug.cgi?id=301241 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-09-24 03:00 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 47a4edef1d6062803c35de7dd81ebbd6 MCP-plugins-0.3.0.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Pacakge ladspa-mcp-plugins-0.3.0-4.fc8 -> Provides: cs_chorus.so cs_phaser.so mcp-plugins = 0.3.0-4.fc8 mvchpf24.so mvclpf24.so Requires: ladspa libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libm.so.6(GLIBC_2.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH) + Not a GUI app. APPROVED. >> Many thanks for all the ladspa reviews, you rock! You welcome :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review