https://bugzilla.redhat.com/show_bug.cgi?id=1684346 Andy Li <andy@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(andy@onthewings.n | |et) | --- Comment #2 from Andy Li <andy@xxxxxxxxxxxxxx> --- Thanks for the review! I've modified the spec accordingly: * Changed license to "MIT and LGPLv2 with exceptions and ISC" * Fixed direction ownership. * Added a %check that print dune's version. Spec URL: https://gist.github.com/andyli/e8837f66df97f8c659f114c063549da5/raw/566433f7b36682edbb23c286e8efa6ee495ce06f/ocaml-dune.spec SRPM URL: https://gist.github.com/andyli/e8837f66df97f8c659f114c063549da5/raw/566433f7b36682edbb23c286e8efa6ee495ce06f/ocaml-dune-1.7.3-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx