[Bug 1684177] Review Request: perl-Alien-FFI - Make available libffi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1684177

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
URL and Source addresses are Ok.
Source archive (SHA-256:
81228cafe0014190025c91d37f8b1dc4889cee4a3add3af10614f803f7b65745) is original.
Ok.
Summary verified from lib/Alien/FFI.pm. Ok.
Description verified from llib/Alien/FFI.pm. Ok.
License verified from lib/Alien/FFI.pm and README. Ok.
No XS code, but arch dependent code: BuildArch is Ok.


$ rpmlint perl-Alien-FFI.spec
review-perl-Alien-FFI/results/perl-Alien-FFI-0.22-1.fc31.src.rpm
review-perl-Alien-FFI/results/perl-Alien-FFI-0.22-1.fc31.x86_64.rpm    
23:45:28
perl-Alien-FFI.src: W: spelling-error Summary(en_US) libffi -> bailiff
perl-Alien-FFI.src: W: spelling-error %description -l en_US libffi -> bailiff
perl-Alien-FFI.x86_64: E: explicit-lib-dependency libffi-devel(x86-64)
perl-Alien-FFI.x86_64: W: spelling-error Summary(en_US) libffi -> bailiff
perl-Alien-FFI.x86_64: W: spelling-error %description -l en_US libffi ->
bailiff
perl-Alien-FFI.x86_64: E: no-binary
2 packages and 1 specfiles checked; 2 errors, 4 warnings.


$ rpm -q -lv -p perl-Alien-FFI-0.22-1.fc31.x86_64.rpm                          
                                                         23:48:13
drwxr-xr-x    2 root    root                        0 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/Alien
drwxr-xr-x    2 root    root                        0 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/Alien/FFI
-rw-r--r--    1 root    root                     1669 août 28  2018
/usr/lib64/perl5/vendor_perl/Alien/FFI.pm
drwxr-xr-x    2 root    root                        0 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/Alien/FFI/Install
-rw-r--r--    1 root    root                      142 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/Alien/FFI/Install/Files.pm
drwxr-xr-x    2 root    root                        0 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/auto
drwxr-xr-x    2 root    root                        0 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/auto/Alien
drwxr-xr-x    2 root    root                        0 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/auto/Alien/FFI
-rw-r--r--    1 root    root                       65 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/auto/Alien/FFI/FFI.txt
drwxr-xr-x    2 root    root                        0 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/auto/share
drwxr-xr-x    2 root    root                        0 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/auto/share/dist
drwxr-xr-x    2 root    root                        0 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/auto/share/dist/Alien-FFI
drwxr-xr-x    2 root    root                        0 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/auto/share/dist/Alien-FFI/_alien
-rw-r--r--    1 root    root                      512 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/auto/share/dist/Alien-FFI/_alien/alien.json
-rw-r--r--    1 root    root                     4107 févr. 28 23:45
/usr/lib64/perl5/vendor_perl/auto/share/dist/Alien-FFI/_alien/alienfile
drwxr-xr-x    2 root    root                        0 févr. 28 23:45
/usr/share/doc/perl-Alien-FFI
-rw-r--r--    1 root    root                     3300 août 28  2018
/usr/share/doc/perl-Alien-FFI/Changes
-rw-r--r--    1 root    root                     1555 août 28  2018
/usr/share/doc/perl-Alien-FFI/README
drwxr-xr-x    2 root    root                        0 févr. 28 23:45
/usr/share/licenses/perl-Alien-FFI
-rw-r--r--    1 root    root                    18349 août 28  2018
/usr/share/licenses/perl-Alien-FFI/LICENSE
-rw-r--r--    1 root    root                     1839 févr. 28 23:45
/usr/share/man/man3/Alien::FFI.3pm.gz
File permissions and layout are Ok.


rpm -q --requires -p perl-Alien-FFI-0.22-1.fc31.x86_64.rpm  | sort -f | uniq -c
                                                       23:49:01
      1 libffi-devel(x86-64)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(Alien::Base) >= 0.73
      1 perl(Alien::FFI)
      1 perl(base)
      1 perl(Config)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.


$ rpm -q --provides -p perl-Alien-FFI-0.22-1.fc31.x86_64.rpm 
perl(Alien::FFI) = 0.22
perl(Alien::FFI::Install::Files)
perl-Alien-FFI = 0.22-1.fc31
perl-Alien-FFI(x86-64) = 0.22-1.fc31
Binary provides are Ok.


Package builds in Koji
(https://koji.fedoraproject.org/koji/taskinfo?taskID=33109771).
Failure on s390x:

+ make test
"/usr/bin/perl" -MAlien::Build::MM=cmd -e test
Alien::Build::Plugin::PkgConfig::Negotiate> Using PkgConfig plugin:
PkgConfig::LibPkgConf
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness"
"-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')"
t/*.t
BUILDSTDERR: # 
BUILDSTDERR: # 
BUILDSTDERR: # 
BUILDSTDERR: # HARNESS_ACTIVE=1
BUILDSTDERR: # HARNESS_VERSION=3.42
BUILDSTDERR: # LANG=C
BUILDSTDERR: #
PERL5LIB=/builddir/build/BUILD/Alien-FFI-0.22/blib/lib:/builddir/build/BUILD/Alien-FFI-0.22/blib/arch
BUILDSTDERR: # PERL_DL_NONLAZY=1
BUILDSTDERR: # PERL_USE_UNSAFE_INC=1
BUILDSTDERR: # SHELL=/bin/bash
BUILDSTDERR: # 
BUILDSTDERR: # 
BUILDSTDERR: # 
BUILDSTDERR: # PERL5LIB path
BUILDSTDERR: # /builddir/build/BUILD/Alien-FFI-0.22/blib/lib
BUILDSTDERR: # /builddir/build/BUILD/Alien-FFI-0.22/blib/arch
BUILDSTDERR: # 
BUILDSTDERR: # 
BUILDSTDERR: # 
BUILDSTDERR: # perl                5.028001
BUILDSTDERR: # Alien::Base         1.55
BUILDSTDERR: # Alien::Build        1.55
BUILDSTDERR: # Alien::Build::MM    1.55
BUILDSTDERR: # Capture::Tiny       0.48
BUILDSTDERR: # ExtUtils::MakeMaker 7.34
BUILDSTDERR: # IPC::Cmd            1.02
BUILDSTDERR: # Test2::V0           0.000118
BUILDSTDERR: # Test::Alien         1.55
BUILDSTDERR: # 
BUILDSTDERR: # 
BUILDSTDERR: # 
BUILDSTDERR: # version        = 3.1
BUILDSTDERR: # cflags         = 
BUILDSTDERR: # cflags_static  = 
BUILDSTDERR: # libs           = -lffi
BUILDSTDERR: # libs_static    = -lffi
BUILDSTDERR: # 
BUILDSTDERR: # 
BUILDSTDERR: # 
t/00_diag.t .. ok
BUILDSTDERR:     # Failed test at t/xs.t line 9.
BUILDSTDERR:     # +-----+----+-------+
BUILDSTDERR:     # | GOT | OP | CHECK |
BUILDSTDERR:     # +-----+----+-------+
BUILDSTDERR:     # | 0   | eq | 4     |
BUILDSTDERR:     # +-----+----+-------+
BUILDSTDERR:     # Failed test at t/xs.t line 10.
BUILDSTDERR:     # +-----+----+-------+
BUILDSTDERR:     # | GOT | OP | CHECK |
BUILDSTDERR:     # +-----+----+-------+
BUILDSTDERR:     # | 0   | eq | 12    |
BUILDSTDERR:     # +-----+----+-------+
BUILDSTDERR: # Failed test 'xs subtest'
BUILDSTDERR: # at t/xs.t line 11.
t/xs.t ....... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests 
Test Summary Report
-------------------
t/xs.t     (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1
Files=2, Tests=4,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.53 cusr  0.13
csys =  0.68 CPU)
Result: FAIL
BUILDSTDERR: Failed 1/2 test programs. 1/4 subtests failed.


Resolution: Package not approved. Please investigate the test failure on s390x.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux