https://bugzilla.redhat.com/show_bug.cgi?id=1680145 --- Comment #4 from Troy Dawson <tdawson@xxxxxxxxxx> --- spec, tarball script, and src.rpm have been updated (In reply to Robert-André Mauchin from comment #3) > - Nitpick: Please have your script remove the temporary archive and > directory it creates. > -- Good idea, added cleanup section at the end of script > > - License: MPLv2.0 and BSD and MIT > > Please add a comment explaining the licenses breakdown. > -- Comments added stating which bundled libraries have which license > - Remove all these useless hidden files in %prep > > > mozilla-iot-gateway-addon-node.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/gateway-addon-node/node_modules/.yarn-integrity > mozilla-iot-gateway-addon-node.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/gateway-addon-node/node_modules/ajv/.tonic_example.js > mozilla-iot-gateway-addon-node.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/gateway-addon-node/node_modules/ajv/lib/.DS_Store > mozilla-iot-gateway-addon-node.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/gateway-addon-node/node_modules/ajv/scripts/.eslintrc. > yml > mozilla-iot-gateway-addon-node.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/gateway-addon-node/node_modules/fast-json-stable- > stringify/.eslintrc.yml > mozilla-iot-gateway-addon-node.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/gateway-addon-node/node_modules/fast-json-stable- > stringify/.npmignore > mozilla-iot-gateway-addon-node.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/gateway-addon-node/node_modules/fast-json-stable- > stringify/.travis.yml > mozilla-iot-gateway-addon-node.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/gateway-addon-node/node_modules/json-schema-traverse/. > eslintrc.yml > mozilla-iot-gateway-addon-node.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/gateway-addon-node/node_modules/json-schema-traverse/. > travis.yml > mozilla-iot-gateway-addon-node.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/gateway-addon-node/node_modules/json-schema-traverse/ > spec/.eslintrc.yml > -- %prep section now cleans up hidden files > > - You should work to unbundle all these node modules. Bundling is usually a > last resort option. > -- Understood -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
