[Bug 1672978] Review Request: python-collectd_puppet - Publishes puppet status to collectd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1672978



--- Comment #2 from Steve Traylen <steve.traylen@xxxxxxx> ---
Hi,

Thanks for the review.

> - The manual requires on Python packages are unnecessary on Rawhide. 
> You can opt in for this on older Fedoras: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies

For the case of 

   Requires:       collectd-python


I don't think it can be auto generated. Even it were added to the setup.py file
the module is in the wrong place.

https://koji.fedoraproject.org/koji/rpminfo?rpmID=16672661

that collectd.so file is probably in the wrong place and should be in a python
directory, the auto provides python3dist(collectd) will never be generated so
long as
it's there.


   $ PYTHONPATH=/usr/lib64 python3
   Python 3.7.2 (default, Jan 16 2019, 19:49:22) 
   [GCC 8.2.1 20181215 (Red Hat 8.2.1-6)] on linux
   Type "help", "copyright", "credits" or "license" for more information.
   >>> import collectd


I'll submit a bug to collectd and reference that in this spec file.

Will give you a while to comment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux