https://bugzilla.redhat.com/show_bug.cgi?id=1666493 Michael.Zhang@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1522183 is| | obsolete| | --- Comment #5 from Michael.Zhang@xxxxxxx --- Hi, Made some changes to the spec file as recommended by the Fedora Guidelines. (1) The package should not be installed inder /opt - moved the package installation dir to /usr/share/openliberty (2) You should provide SystemD files, not init.d ones - moved the openliberty script from /etc/init.d/openliberty to /usr/libexec/openliberty and created the relevant service files (under /usr/lib/systemd/system/openliberty@.service) to use SystemD instead of SystemV init. (3) You need to include a changelog entry - created an changelog entry detailing the changes >From your previous comment of: - "It is forbidden to ship jar files directly:" I'm assuming you wish for us to incorporate the jar building process into our travis build process. So there are 2 ways we can go about this: (1) call rpmbuild - which would then have to call gradle inside to build straight from the source and package as rpm all in 1 rpm command (2) call gradle to build the necessary jars then call rpmbuild to package the contents into a rpm We would much rather prefer the 2nd option as it is easier and more convenient on our end. Note: the Travis Build process and Github Repo will soon be made public. When running rpmlint on our package, we get the "openliberty.noarch: W: invalid-license EPL-1.0" warning. I believe that the EPL-1.0 (Eclipse Public License 1.0) is under the list of acceptable licenses so why am I seeing this warning? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
