https://bugzilla.redhat.com/show_bug.cgi?id=1680140 --- Comment #2 from Troy Dawson <tdawson@xxxxxxxxxx> --- Thank you for finding those problems. The spec and src.rpm have been updated to fix these issues. (In reply to Robert-André Mauchin from comment #1) > - The description should be split into multiple lines to stay below 80 > characters per line. > - Description has been reformted into multiple lines, each below 80 characters > - Don't glob the major SONAME version to avoid unintentional SONAME bump: > > %{_libdir}/libnanomsg.so.* > - major SONAME version is not globed anymore %{_libdir}/libnanomsg.so.5* > - The license file must be installed with %license not %doc: > > %license COPYING > - good catch, fixed > - Use a better name for your archive: > > Source0: > https://github.com/nanomsg/nanomsg/archive/%{version}/%{name}-%{version}.tar. > gz > - Source0 has been updated. -- I had tried to find the correct URL for that but it kept failing for me. I must have had a typo. Anyway, thank you for the link. > - Consider making a separate noarch subpackage for the docs > - Made a seperate subpackage for the docs -- the docs subpackage is not noarch. Because the docs are compiled, it is possible for them to be different between arches. -- I did try the docs as a noarch, but it failed on a scratch build on koji due to the files not matching between arches. > - Capitalize the summary > - Capitalized the summary -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
