https://bugzilla.redhat.com/show_bug.cgi?id=1680372 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- URL and Source addresses are Ok. Source archive (SHA-256: 9ffb4554a3c98273b6622181e81c6e18c3c6d02eebf3d8524cc3f017d613cecc) is original. Ok. Summary verified from lib/GitLab/API/v4.pm. Ok. Description verified from lib/GitLab/API/v4.pm. Ok. License verified from lib/GitLab/API/v4.pm and README.md. Ok. No XS code, noarch BuildArch is Ok. $ rpmlint perl-GitLab-API-v4.spec review-perl-GitLab-API-v4/results/perl-GitLab-API-v4-0.17-0.2.fc31.noarch.rpm review-perl-GitLab-API-v4/results/perl-GitLab-API-v4-0.17-0.2.fc31.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpm -q -lv -p perl-GitLab-API-v4-0.17-0.2.fc31.noarch.rpm -rwxr-xr-x 1 root root 5289 févr. 20 23:48 /usr/bin/gitlab-api-v4 drwxr-xr-x 2 root root 0 févr. 24 18:35 /usr/share/doc/perl-GitLab-API-v4 -rw-r--r-- 1 root root 4808 févr. 20 23:48 /usr/share/doc/perl-GitLab-API-v4/Changes -rw-r--r-- 1 root root 117576 févr. 20 23:48 /usr/share/doc/perl-GitLab-API-v4/README.md drwxr-xr-x 2 root root 0 févr. 24 18:35 /usr/share/licenses/perl-GitLab-API-v4 -rw-r--r-- 1 root root 18424 févr. 20 23:48 /usr/share/licenses/perl-GitLab-API-v4/LICENSE -rw-r--r-- 1 root root 2915 févr. 24 18:35 /usr/share/man/man1/gitlab-api-v4.1.gz -rw-r--r-- 1 root root 15774 févr. 24 18:35 /usr/share/man/man3/GitLab::API::v4.3pm.gz -rw-r--r-- 1 root root 2940 févr. 24 18:35 /usr/share/man/man3/GitLab::API::v4::Config.3pm.gz -rw-r--r-- 1 root root 2387 févr. 24 18:35 /usr/share/man/man3/GitLab::API::v4::Constants.3pm.gz -rw-r--r-- 1 root root 2649 févr. 24 18:35 /usr/share/man/man3/GitLab::API::v4::Paginator.3pm.gz -rw-r--r-- 1 root root 2118 févr. 24 18:35 /usr/share/man/man3/GitLab::API::v4::RESTClient.3pm.gz drwxr-xr-x 2 root root 0 févr. 24 18:35 /usr/share/perl5/vendor_perl/GitLab drwxr-xr-x 2 root root 0 févr. 24 18:35 /usr/share/perl5/vendor_perl/GitLab/API drwxr-xr-x 2 root root 0 févr. 24 18:35 /usr/share/perl5/vendor_perl/GitLab/API/v4 -rw-r--r-- 1 root root 360668 févr. 20 23:48 /usr/share/perl5/vendor_perl/GitLab/API/v4.pm -rw-r--r-- 1 root root 5791 févr. 20 23:48 /usr/share/perl5/vendor_perl/GitLab/API/v4/Config.pm -rw-r--r-- 1 root root 3157 févr. 20 23:48 /usr/share/perl5/vendor_perl/GitLab/API/v4/Constants.pm -rw-r--r-- 1 root root 4008 févr. 20 23:48 /usr/share/perl5/vendor_perl/GitLab/API/v4/Paginator.pm File permissions and layout are Ok. rpm -q --requires -p perl-GitLab-API-v4-0.17-0.2.fc31.noarch.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(:VERSION) >= 5.10.1 1 perl(Carp) 1 perl(Const::Fast) 1 perl(Exporter) 1 perl(Getopt::Long) 1 perl(GitLab::API::v4) 1 perl(GitLab::API::v4::Config) 1 perl(GitLab::API::v4::Constants) 1 perl(GitLab::API::v4::Paginator) 1 perl(GitLab::API::v4::RESTClient) 1 perl(HTTP::Tiny) 1 perl(HTTP::Tiny::Multipart) 1 perl(IO::Prompter) 1 perl(JSON) 1 perl(Log::Any) 1 perl(Log::Any::Adapter) 1 perl(Log::Any::Adapter::Screen) 1 perl(Moo) 1 perl(namespace::clean) 1 perl(Path::Tiny) 1 perl(Pod::Usage) 1 perl(strictures) >= 2 1 perl(Try::Tiny) 1 perl(Types::Common::Numeric) 1 perl(Types::Common::String) 1 perl(Types::Standard) 1 perl(URI) 1 perl(URI::Escape) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. - Add BR for test: BuildRequires: perl(IPC::Cmd) $ rpm -q --provides -p perl-GitLab-API-v4-0.17-0.2.fc31.noarch.rpm perl(GitLab::API::v4) = 0.17 perl(GitLab::API::v4::Config) = 0.17 perl(GitLab::API::v4::Constants) = 0.17 perl(GitLab::API::v4::Paginator) = 0.17 perl(GitLab::API::v4::RESTClient) = 0.17 perl-GitLab-API-v4 = 0.17-0.2.fc31 Package builds in Mock. Ok Resolution: Package not approved. Please fix all the aforementioned points. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx