[Bug 1680375] Review Request: perl-Log-Any-Adapter-Screen - Send logs to screen, with colors and some other features

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1680375

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
URL and Source addresses are Ok.
Source archive (SHA-256:
992bf35d49684bbdc69c9c84bb7088e57c878b812bc42e631bd2697e1ab088ae) is original.
Ok.
Summary verified from lib/Log/Any/Adapter/Screen.pm. Ok.
Description verified from lib/Log/Any/Adapter/Screen.pm. Ok.
License verified from lib/Log/Any/Adapter/Screen.pm and README. Ok.
No XS code, noarch BuildArch is Ok.


$ rpmlint perl-Log-Any-Adapter-Screen.spec
review-perl-Log-Any-Adapter-Screen/results/perl-Log-Any-Adapter-Screen-0.140-0.2.fc31.noarch.rpm
review-perl-Log-Any-Adapter-Screen/results/perl-Log-Any-Adapter-Screen-0.140-0.2.fc31.src.rpm 
perl-Log-Any-Adapter-Screen.noarch: W: spelling-error %description -l en_US
formatter -> formatted, for matter, for-matter
perl-Log-Any-Adapter-Screen.noarch: W: spelling-error %description -l en_US
timestamps -> time stamps, time-stamps, times tamps
perl-Log-Any-Adapter-Screen.src: W: spelling-error %description -l en_US
formatter -> formatted, for matter, for-matter
perl-Log-Any-Adapter-Screen.src: W: spelling-error %description -l en_US
timestamps -> time stamps, time-stamps, times tamps
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

$ rpm -q -lv -p perl-Log-Any-Adapter-Screen-0.140-0.2.fc31.noarch.rpm          
                             18:21:59
drwxr-xr-x    2 root    root                        0 févr. 24 18:18
/usr/share/doc/perl-Log-Any-Adapter-Screen
-rw-r--r--    1 root    root                     2028 déc. 22 01:57
/usr/share/doc/perl-Log-Any-Adapter-Screen/Changes
-rw-r--r--    1 root    root                     5006 déc. 22 01:57
/usr/share/doc/perl-Log-Any-Adapter-Screen/README
drwxr-xr-x    2 root    root                        0 févr. 24 18:18
/usr/share/licenses/perl-Log-Any-Adapter-Screen
-rw-r--r--    1 root    root                    18457 déc. 22 01:57
/usr/share/licenses/perl-Log-Any-Adapter-Screen/LICENSE
-rw-r--r--    1 root    root                     3262 févr. 24 18:18
/usr/share/man/man3/Log::Any::Adapter::Screen.3pm.gz
drwxr-xr-x    2 root    root                        0 févr. 24 18:18
/usr/share/perl5/vendor_perl/Log
drwxr-xr-x    2 root    root                        0 févr. 24 18:18
/usr/share/perl5/vendor_perl/Log/Any
drwxr-xr-x    2 root    root                        0 févr. 24 18:18
/usr/share/perl5/vendor_perl/Log/Any/Adapter
-rw-r--r--    1 root    root                     8608 déc. 22 01:57
/usr/share/perl5/vendor_perl/Log/Any/Adapter/Screen.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-Log-Any-Adapter-Screen-0.140-0.2.fc31.noarch.rpm |
sort -f | uniq -c             18:22:44
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(:VERSION) >= 5.10.1
      1 perl(Log::Any)
      1 perl(Log::Any::Adapter::Base)
      1 perl(Log::Any::Adapter::Util)
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

 - Add BR for

BuildRequires:  perl(Log::Any::Adapter::Base)
# Tests
BuildRequires:  perl(Test::Perl::Critic)
BuildRequires:  perl(Test::Pod) >=  1.41
BuildRequires:  perl(Test::Pod::Coverage) >= 1.08
BuildRequires:  perl(Pod::Coverage::TrustPod)


$ rpm -q --provides -p perl-Log-Any-Adapter-Screen-0.140-0.2.fc31.noarch.rpm   
                             18:30:51
perl(Log::Any::Adapter::Screen) = 0.140
perl-Log-Any-Adapter-Screen = 0.140-0.2.fc31
Binary provides are Ok.


Package builds in Koji
(https://koji.fedoraproject.org/koji/taskinfo?taskID=33012894).
Ok



Resolution: Package not approved. Please fix all the aforementioned points.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux