https://bugzilla.redhat.com/show_bug.cgi?id=1680373 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #7 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - CONTRIBUTORS should be in %doc not %license URL and Source addresses are Ok. Source archive (SHA-256: ed0d43d470797c236be7f83e414e31561560ef3f88fab1ec09def20d98c361d6) is original. Ok. Summary verified from lib/HTTP/Tiny/Multipart.pm. → Use: "Add post_multipart to HTTP::Tiny" Description verified from lib/HTTP/Tiny/Multipart.pm. → Use: "Add post_multipart to HTTP::Tiny" License verified from lib/HTTP/Tiny/Multipart.pm and LICENSE. Ok. No XS code, noarch BuildArch is Ok. $ rpmlint perl-HTTP-Tiny-Multipart.spec review-perl-HTTP-Tiny-Multipart/results/perl-HTTP-Tiny-Multipart-0.08-0.3.fc31.noarch.rpm review-perl-HTTP-Tiny-Multipart/results/perl-HTTP-Tiny-Multipart-0.08-0.3.fc31.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpm -q -lv -p perl-HTTP-Tiny-Multipart-0.08-0.3.fc31.noarch.rpm drwxr-xr-x 2 root root 0 févr. 24 18:07 /usr/share/doc/perl-HTTP-Tiny-Multipart -rw-r--r-- 1 root root 1550 avril 30 2018 /usr/share/doc/perl-HTTP-Tiny-Multipart/Changes drwxr-xr-x 2 root root 0 févr. 24 18:07 /usr/share/licenses/perl-HTTP-Tiny-Multipart -rw-r--r-- 1 root root 389 avril 30 2018 /usr/share/licenses/perl-HTTP-Tiny-Multipart/CONTRIBUTORS -rw-r--r-- 1 root root 9042 avril 30 2018 /usr/share/licenses/perl-HTTP-Tiny-Multipart/LICENSE -rw-r--r-- 1 root root 1730 févr. 24 18:07 /usr/share/man/man3/HTTP::Tiny::Multipart.3pm.gz drwxr-xr-x 2 root root 0 févr. 24 18:07 /usr/share/perl5/vendor_perl/HTTP drwxr-xr-x 2 root root 0 févr. 24 18:07 /usr/share/perl5/vendor_perl/HTTP/Tiny -rw-r--r-- 1 root root 5136 avril 30 2018 /usr/share/perl5/vendor_perl/HTTP/Tiny/Multipart.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-HTTP-Tiny-Multipart-0.08-0.3.fc31.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(Carp) 1 perl(File::Basename) 1 perl(HTTP::Tiny) 1 perl(MIME::Base64) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. Add all BR for tests: BuildRequires: perl(HTTP::Tiny::Multipart) BuildRequires: perl(Test::Pod) >= 1.41 BuildRequires: perl(Test::Pod::Coverage) >= 1.08 BuildRequires: perl(Pod::Coverage::TrustPod) $ rpm -q --provides -p perl-HTTP-Tiny-Multipart-0.08-0.3.fc31.noarch.rpm perl(HTTP::Tiny::Multipart) = 0.08 perl-HTTP-Tiny-Multipart = 0.08-0.3.fc31 Binary provides are Ok. Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=33012716). Ok Resolution: Package not approved. Please fix all the aforementioned points. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
