[Bug 1671571] Review Request: playerctl - MPRIS command-line controller and library for spotify, vlc, audacious, bmp, cmus, and others

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1671571



--- Comment #19 from Neal Gompa <ngompa13@xxxxxxxxx> ---
(In reply to Dridi Boukelmoune from comment #18)
> 
> Now there are a few things I'm not too happy with in this spec at a single
> glance:
> 
> The main package should not need to require the -libs sub-package, it should
> be detected automatically via linker information in binaries.
> 

This is actually a matter of policy for interdependencies like this. This
prevents weird things from happening because often private symbols are used
from -libs subpackage from other parts of the same source package. That, of
course, is not true for external consumers.

> 
> After that I'll be happy to move on to a formal review, but my availability
> will be limited for a couple weeks.

I can take over the review if you want?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux