[Bug 301741] Review Request: whowatch - Display information about users currently logged on users

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: whowatch - Display information about users currently logged on users


https://bugzilla.redhat.com/show_bug.cgi?id=301741





------- Additional Comments From michel.sylvan@xxxxxxxxx  2007-09-23 14:02 EST -------
Apart from the tarball mismatch (please use upstream's), the licensing is also
problematic. The source files do not have any license header, so the only
license information we have is from the COPYING file. The license should thus be
GPLv2 for now, and you might want to ask upstream before adding the '+'.

The summary field has a typo: remove the last 'users'?

The build root is valid, but it's the least preferred:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473

Consider switching to the first.

Also, the changelog entry is a bit weird -- first changelog should probably say
"Initial package" or something similar. If spec is modified from an earlier
package, cite which one.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]