Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pidgin-plugin_pack - A set of plugins for pidgin https://bugzilla.redhat.com/show_bug.cgi?id=255461 michel.sylvan@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From michel.sylvan@xxxxxxxxx 2007-09-23 02:10 EST ------- Did not notice this until I submitted my review request. I'll review this instead. Two points: would you consider splitting the package up? upstream has purple-plugin_pack and pidgin-plugin_pack; the former is usable from, e.g Finch (I looked and there is no Finch-only plugin right now) - Missing BR on gtkspell-devel - Chopping off xmms is a good idea, but in your spec nobody owns %{_datadir}/pixmaps/pidgin/plugin_pack . Add that as %dir in the main package? Would get annoying once other plugins start putting files there, I suppose. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review