https://bugzilla.redhat.com/show_bug.cgi?id=1678233 --- Comment #2 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- > %define unmangled_version 0.6.5 > %define unmangled_version 0.6.5 Any reason to define it twice? > %define name rpm2swidtag > %define version 0.6.5 > %define release 1%{dist} Any reason to define them when it is not used? BTW every tag will define a corresponding macro. So Name will define %name. So this has no use because it is overridden by a tag below. > Summary: Tools for producing SWID tags from rpm package headers and inspecting the SWID tags The summary should be shorter than 80 characters. Can you try to make it a bit shorter? > Release: 1%{dist} This should be `1%{?dist}` so it produces valid output in case of dist macro is not defined. > Group: Development/Libraries This tag has no use and it should be removed. > BuildRequires: fakeroot It would be nice if you can separate aside - with a comment - the buildrequires which are needed only for %check section. > %package -n dnf-plugin-swidtags I would advise putting "Recommend: dnf" in this sub-package. > %clean > rm -rf $RPM_BUILD_ROOT This section is not used nowadays and should be removed entirely. > --root=$RPM_BUILD_ROOT Use macros consistently. Either old style or the new style. I recommend to use `--root=%{buildroot}` > # %license LICENSE Any reason why LICENSE is not included in tar ball? Especially when you are upstream as well? You are missing %dir %{_sysconfdir}/%{name} in %files. Who owns `%{_sysconfdir}/swid/` and `/usr/share/swidq` ? Hint - it should be either you or some your dependency. > %config(noreplace) %{_sysconfdir}/%{name}/%{name}.conf.d You probably meant: %dir %{_sysconfdir}/%{name}/%{name}.conf.d %config(noreplace) %{_sysconfdir}/%{name}/%{name}.conf.d/* > %{_bindir}/rpm2swidtag > %{_bindir}/swidq It would be really nice if you can write a man page for these two. You are missing a %changelog section. All python modules should BuildRequire python3-devel > %{__python3} setup.py build You should use %py3_build macro. > %{__python3} setup.py install --single-version-externally-managed --single-version-externally-managed -O1 --root=$RPM_BUILD_ROOT --record=INSTALLED_FILES You should use %py3_install plus some custom option if needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
