[Bug 1677079] Review Request: cros-guest-tools - Tools for Chromium OS integration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1677079



--- Comment #2 from Jason Montleon <jmontleo@xxxxxxxxxx> ---
Thank you, I made corrections and have an updated build:

https://copr-be.cloud.fedoraproject.org/results/jmontleon/crostini/fedora-29-x86_64/00859481-cros-guest-tools/cros-guest-tools.spec
https://copr-be.cloud.fedoraproject.org/results/jmontleon/crostini/fedora-29-x86_64/00859481-cros-guest-tools/cros-guest-tools-1.0-0.4.20190213gitbf01129.fc29.src.rpm

- Removed the group. From what I can see similar packages are either
Unspecified or Applications/System, but
https://fedoraproject.org/wiki/RPMGroups says that group is deprecated.
- Added the snapshot date and updated the release as described, preceded with a
'0.' and including the snapshot date.
- Removed the debug_package global
- Used macros in the Source0 line as described
- Used desktop-file-validate to install the desktop file
- Used systemd_user_post and systemd_user_preun scriptlets for systemd user
service files
- Owned /etc/gtk-3.0
- Removed dots from end of summary lines
- Wrapped descriptions at 80 or less characters.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux