[Bug 1415612] Review Request: sqlrelay - Database proxy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1415612

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #6 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - make → %make_build

 - make install DESTDIR=%{buildroot} → %make_install

 - Not sure what you're doing here

%postun server-devel
rmdir %{_includedir}/%{name} 2> /dev/null || :
rmdir %{_includedir}/%{name}/private 2> /dev/null || :

   instead you should own the dir:

%dir %{_includedir}/%{name}
%dir %{_includedir}/%{name}/private


 - Same

%postun c++-devel
rmdir %{_includedir}/%{name} 2> /dev/null || :
rmdir %{_includedir}/%{name}/private 2> /dev/null || :

%postun c-devel
rmdir %{_includedir}/%{name} 2> /dev/null || :
rmdir %{_includedir}/%{name}/private 2> /dev/null || :

%postun -n python3-%{name}
rmdir %{python3_sitearch}/SQLRelay/__pycache__ 2> /dev/null || :
rmdir %{python3_sitearch}/SQLRelay 2> /dev/null || :

and so on

 - You should not glob the major soname version to avoid accidentally bumping
the soname:

%{_libdir}/libsqlrserver.so.*
%{_libdir}/libsqlrutil.so.*



 - /sbin/ldconfig is not needed anymore, remove them all

 -

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux