https://bugzilla.redhat.com/show_bug.cgi?id=1674278 --- Comment #20 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> --- Now you need to make it use the default fedora compiler flags, currently it has none + /usr/bin/make -O -j8 CC=gcc building ttyclock.c gcc -Wall -g $(pkg-config --cflags ncurses) ttyclock.c -o tty-clock $(pkg-config --libs ncurses) + exit 0 https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags also your changelog is wrong still, each new build requires that you bump the release tag Release: 3%{?dist} As for the changelog version, it needs to match package version Version: 2.3 * Wed Feb 13 2019 Dragos Iorga <idf31@xxxxxxxxxxxxxx> - 2.3-4 - Fixed bogus date - Added gcc to BuildRequire * Tue Feb 12 2019 Dragos Iorga <idf31@xxxxxxxxxxxxxx> - 2.3-3 - Made Source0 less repetitive * Mon Feb 11 2019 Dragos Iorga <idf31@xxxxxxxxxxxxxx> - 2.3-2 - Fixed typo * Sun Feb 10 2019 Dragos Iorga <idf31@xxxxxxxxxxxxxx> - 2.3-1 - Initial Commit - Fixed broken URL - Fixed bad paths - Fixed wrong license name I also recommend the you use my suggested source tag as it produces a correctly named tarball Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz then you can remove -n tty-clock-%{version} from %prep %autosetup -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
