https://bugzilla.redhat.com/show_bug.cgi?id=1658153 --- Comment #26 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to J. Scheurich from comment #22) > 2. Why "Requires: kolourpaint" and not, say, gimp? [snip] > The image editor setting is in options in the GUI... That's my point. Why is the spec file *forcing* every person who installs wdune to also install kolourpaint? That's what Requires does. If there are multiple possible image editors, then we shouldn't force everybody to install one particular image editor. Instead of Requires, use Recommends or Suggests, something like this: Suggests: image_editor_1 Suggests: image_editor_2 ... That way, when a person chooses to install wdune, they can also choose an image editor. > 3. Why "Requires: lxterminal"? That's wrong for users who are not using > LXDE. [snip] > If you don't want lxterminal, you can change this in options in the GUI Same thing. Why force every person who installs wdune to also install lxterminal? Why not list suitable terminals in Recommends or Suggests clauses, and let each person who installs choose? > 4. Add "Requires: coreutils" since the code invokes cat, echo, ls, mkdir, > etc. It's probably silly, since who could have a system with no coreutils? > Nevertheless, humor me. > 5. Likewise, add "Requires: grep", since I see grep being invoked as well. > > The runtime do not invoke cat grep etc. so coreutils and grep are a > BuildRequires, i will fix that No, you don't need to have BuildRequires: coreutils. That is automatically part of the buildroot. Okay, I see. Those tools are invoked from awk and bash scripts. Those scripts are only executed at build time? I'm talking about tools/modify_orientation_interpolator.awk (invokes echo), batch/findcopyrights.sh (invokes cat and grep), batch/print_unused_geo_files.sh (invokes ls), and what appears to be a genuine source file: src/swt/motif/swt.c (invokes mkdir). > 7. There are a lot of licenses in this code. I'm not confident that GPLv3+ > is an accurate summation of them. > > In short. there are 5 types of licenses in the code > - GPL2 > - GPL3 > - MIT > - LGPL > - permisson ro copy and modify > > GPL3 is the summation of it or what should i use instead of it ? > > If you declare a permisson ro copy and modify license as GPL3, this is > legal, GPL3 only adds restrictions. Okay. I saw such a large volume of output from licensecheck that it was confusing for me. The cases I was worried about were files that licensecheck reported as GPLv2 only. But on inspection, it looks like all of those files are dual licensed, so that's okay. I also saw a mention of the GFDL, but that appears to be limited to packager/Announcements/freewaredirectory_template_dune.txt, which is not included in the binary RPMs. So the license field is okay. The bundled eigen3 code is licensed under the Mozilla Public License v2.0, but we'll talk about that next. > 8. The code in vcglib/eigenlib looks like a bundled copy of eigen3. Please > check whether it is or not. If it is, it needs to be unbundled. > > It lloks like vcglib includes some files of eigen3, but there are more > (header) files. > I have big problems to find a sponsor for wdune, it would make the task much > more difficult to get a sposor for vcglib 8-( > So i added vcglib which is only a bunch of include headers, not a real > library. > white_dune still compiles without vcglib, but the imprtant feature "mesh > reducer" would not be available 8-( > I have the choice to remove vcgib or not 8-( So we have a bundled vcglib which contains a bundled eigen3. I'm sorry to slow things down for you, but we really do need to unbundle both of those libraries if at all possible. Has either library been modified from its upstream form? If not, I'll have to ask you to submit a vcglib review (with eigen3 unbundled), and make wdune consume vcglib. I can sponsor you as well on the vcglib review as on this one, so that won't be an obstacle. Speaking of getting sponsored, what reviews have you done? I'd like to see how good of a grasp you are getting on the Fedora packaging guidelines. Feel free to contact me via email about that if you prefer doing so to replying here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
