[Bug 1676914] Review Request: oraculum - Backend and API for Fedora QA Dashboard

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1676914



--- Comment #5 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
https://pypi.org/project/Flask-Cache/ and
https://pypi.org/project/Flask-Caching/ are 2 different packages.

The first is imported as flask_cache, the second as flask_caching.

python-flask-cache is Flask-Cache, if you want to depend on Flask-Caching, you
need to package that one first.

Your code has:

  # This mess is required, because flask_cache is 'obsolete' and not working
  #  in PiP, and is replaced with flask_caching, but in Fedora, the
flask_caching
  #  implementation is just used in flask_cache package instead....
  try:
      from flask_caching import Cache
  except ModuleNotFoundError:
      from flask_cache import Cache

That comment is a lie. python-flask-cache in Fedora is Flask-Cache, sources
point to
https://pypi.python.org/packages/source/F/Flask-Cache/Flask-Cache-0.13.1.tar.gz
and there are no patches that change it Flask-Caching.

----------

> we'll discuss if we actually want noreplace.

Either you put it in /etc as %config(noreplace), or you put it in /usr without
%config.

Files in /etc are meant to be edited by users (roots) and you shall not
override user changes.

Files in /usr are not meant to be edited by users and you are OK overriding
such changes.

%config without noreplace would need a thorough justification:

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_configuration_files


> and directory should be owned by httpd package.

In that case, you'll need to require httpd.
If you want to avoid hard requirement on httpd but still keep the file, you
need to co-own the directory.

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux