https://bugzilla.redhat.com/show_bug.cgi?id=1674530 Gergely Gombos <gombosg@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gombosg@xxxxxxxxx --- Comment #1 from Gergely Gombos <gombosg@xxxxxxxxx> --- I almost posted my unofficial review, then it disappeared :( This is a nice app! So the important points: - A rename may be imminent, but the binary name is still gradio so the package name is OK even if e.g. the URL already contains Shortwave. - Where you use subdirectories, add all the directories to %files so that everything is owned by the package (e.g. /usr/share/icons/hicolor/32x32 etc.) - Builds fine in rawhide mock, runs fine on F29 - Create a macro like %{archivename} for %{appname}-v%{version} - License is fine as GPLv3 since source files are like LGPLv2+ etc. (all GPLv3 distributable) so it's ok that upstream chose GPLv3 for all files. - There are .h files in the debugsource file because the source contains a 'libgd' as a build source. Since there is no separate library file built, there is no need for a -devel package where these .h files could go. Otherwise LGTM, but a more experienced reviewer may be more helpful than me. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
