https://bugzilla.redhat.com/show_bug.cgi?id=1674181 Jeremy Cline <jeremy@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |jeremy@xxxxxxxxxx Flags| |fedora-review? --- Comment #3 from Jeremy Cline <jeremy@xxxxxxxxxx> --- fedora-review's output is very noisy, so I've included all my comments up here along with the complete output below. 1. The packaging guidelines require that the unversioned shared libraries be shipped in the -devel package (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages) unless there's no versioned version. You'll want to change your %files section so dino only includes the versioned so files. It looks like the plugins only ship unversioned varieties so those can go in the main package. 2. I think you need to make use of %find_lang (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_handling_locale_files). Additionally it doesn't seem to like zh_Hans, I think it's supposed to be zh-Hans. 3. I think you need to run desktop-file-validate (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files) The other issues look to be outdated. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports/dino.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports /gpgme-vala.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports/gpgme_fix.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports/qlite.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports /signal-protocol-vala.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports/signal/curve.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports/signal/key_helper.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports/signal/protocol.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports/signal/ratchet.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports/signal/session_builder.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports/signal/session_cipher.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports/signal/session_pre_key.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports/signal/signal_protocol.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports/signal/signal_protocol_types.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports/signal_helper.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/build/exports /xmpp-vala.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/LocalStorageProtocol.pb-c.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/WhisperTextProtocol.pb-c.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/curve.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/curve25519/curve25519-donna.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/additions/crypto_additions.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/additions/crypto_hash_sha512.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/additions/curve_sigs.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/additions/generalized/gen_crypto_additions.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/additions/generalized/gen_eddsa.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/additions/generalized/gen_labelset.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/additions/generalized/gen_veddsa.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/additions/generalized/gen_x.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/additions/keygen.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/additions/xeddsa.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/additions/zeroize.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/fe.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/ge.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/ge_add.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/ge_madd.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/ge_msub.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/ge_p2_dbl.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/ge_sub.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/nacl_includes/crypto_int32.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/nacl_includes/crypto_int64.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/nacl_includes/crypto_uint32.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/nacl_includes/crypto_uint64.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/nacl_includes/crypto_verify_32.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/pow22523.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/pow225521.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/sc.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal- protocol-c/src/curve25519/ed25519/tests/internal_fast_tests.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/hkdf.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/protobuf-c/protobuf-c.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/protocol.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/ratchet.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/sender_key.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/sender_key_record.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/sender_key_state.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/session_builder.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/session_builder_internal.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/session_pre_key.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/session_record.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/session_state.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/signal_protocol.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/signal_protocol_internal.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/signal_protocol_types.h dino- debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/utarray.h dino-debugsource : /usr/src/debug/dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64/plugins /signal-protocol/libsignal-protocol-c/src/vpool.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in dino See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in dino See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in dino See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated", "BSD 2-clause "Simplified" License", "GNU Lesser General Public License (v2.1 or later)", "ISC License", "Expat License", "BSD 3-clause "New" or "Revised" License", "BSD (unspecified)". 576 files have unknown license. Detailed output of licensecheck in /home/vagrant/1674181-dino/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/zh_Hans/LC_MESSAGES, /usr/share/locale/zh_Hans [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/locale/zh_Hans, /usr/share/dbus-1, /usr/share/vala/vapi, /usr/share/dbus-1/services, /usr/share/locale/zh_Hans/LC_MESSAGES, /usr/share/vala [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id/c7(grub2 -tools-extra, e2fsprogs, glibc, kbd, python3-libs, dbus-broker, util- linux, pam), /usr/lib/.build-id(libtevent, openssh-clients, libuser, python3-cccolutils, lmdb-libs, less, libpipeline, iputils, lz4-libs, deltarpm, kbd, device-mapper, libusbx, iproute, rpm-build-libs, libnghttp2, findutils, perl-Unicode-Normalize, popt, zstd, gdbm, sudo, pkgconf, openssl-libs, libsss_idmap, gobject-introspection, systemd, util-linux, libpwquality, libpcap, python3-rpm, libnfsidmap, ykpers, libacl, gdb-headless, krb5-workstation, trousers, libnl3, libsecret, os-prober, gmp, policycoreutils, bzip2-libs, python3-dbus, python3-gpg, freetype, unzip, polkit-pkla-compat, dbus-libs, parted, sssd-kcm, libdb-utils, systemd-libs, perl-Socket, cpio, mozjs60, python3-libsemanage, python2-rpm, libcom_err, grubby, libtool-ltdl, libkcapi-hmaccalc, lzo, libseccomp, gnutls, pcre2, python3, perl- Digest-SHA, libini_config, xz, libss, perl-Params-Util, libtirpc, p11-kit, libyaml, iptables-libs, rpm-build, libpath_utils, file-libs, python3-gobject-base, cryptsetup-libs, krb5-libs, perl-MIME-Base64, sqlite-libs, perl-threads, syslinux-extlinux, perl-Params-Validate, libarchive, gc, libldb, enchant, libselinux-utils, libsmartcols, shared-mime-info, python3-audit, rpm-plugin-systemd-inhibit, json-c, libblkid, compat-openssl10, audit-libs, perl-Data-Dumper, dwz, fuse- libs, polkit, sed, libgcc, libsigsegv, libkadm5, libsss_autofs, libsss_sudo, libssh, perl-threads-shared, python2-lxml, gettext-libs, python2-cffi, libicu, kmod, rsync, libyubikey, sssd-common, python3-hawkey, libunistring, keyutils-libs, perl-Encode, glibc, python2-cryptography, mkpasswd, libgpg-error, fakeroot-libs, shadow- utils, lua-libs, kpartx, libpng, gpgme, grub2-tools-extra, fipscheck, sssd-client, perl-interpreter, net-tools, python3-unbound, rpm-plugin- selinux, gawk, dhcp-libs, libzstd, libbasicobjects, libfdisk, c-ares, usermode, libgcrypt, bash, glibc-common, linux-atm-libs, libsolv, libedit, libxkbcommon, openssh, libuuid, fuse3-libs, python2-krbv, acl, libmount, jansson, perl-Unicode-UTF8, hardlink, hostname, guile, perl-Net-SSLeay, e2fsprogs-libs, glib2, binutils, libattr, perl- Digest-MD5, bind-export-libs, perl-Variable-Magic, python3-pyrsistent, libsss_nss_idmap, brotli, gnupg2, libstdc++, libcollection, libmnl, gnupg2-smime, mtools, grub2-tools, perl-Filter, trousers-lib, systemd- container, perl-IO, rpm, pigz, python3-pycurl, pcre, vim-minimal, syslinux, librepo, python3-libcomps, zip, ima-evm-utils, libxcrypt, systemd-bootchart, systemd-pam, NetworkManager-libnm, libverto, python3-libdnf, polkit-libs, python3-libselinux, python3-cryptography, NetworkManager, dracut, git-core, libkcapi, cracklib, procps-ng, audit, groff-base, libcroco, drpm, npth, python3-psutil, ncurses, qrencode-libs, python3-libs, python3-kerberos, perl-libs, unbound- libs, libevent, perl-Scalar-List-Utils, createrepo_c-libs, libtalloc, perl-PathTools, libtdb, grep, elfutils-libs, perl-Sort-Key, zlib, libtasn1, patch, rpm-sign-libs, fuse3, libbabeltrace, hunspell, libdnf, libsemanage, perl-PerlIO-utf8_strict, libselinux, python2-libs, libmodulemd1, libnsl2, libndp, xfsprogs, libassuan, tar, libcomps, libxml2, expat, systemd-udev, iproute-tc, python3-lxml, openssl, python3-setools, fipscheck-lib, dhcp-client, e2fsprogs, file, libxslt, curl, chkconfig, xz-libs, btrfs-progs, bzip2, libargon2, timedatex, perl-Package-Stash-XS, libcurl, make, python3-markupsafe, gettext, perl-Storable, man-db, coreutils, python3-cffi, python2, libcap-ng, which, elfutils-libelf, libcap, pam, libgomp, openssh- server, sssd-nfs-idmap, libatomic_ops, p11-kit-trust, libdb, libpkgconf, passwd, device-mapper-libs, pinentry, python2-pycurl, fuse-sshfs, libutempter, kmod-libs, ncurses-libs, libidn2, openldap, zchunk-libs, libmetalink, dbus-broker, libffi, desktop-file-utils, readline, python3-pyyaml, checkpolicy, fakeroot, libpsl, libsss_certmap, rpm-libs, libref_array, gdbm-libs, diffutils, python2-kerberos, openssl-pkcs11, ipcalc, nettle, chrony, createrepo_c, grub2-tools-minimal, libipt, cyrus-sasl-lib, libsepol, libdhash, gzip, perl-version, libksba, elfutils, mpfr), /usr/lib /.build-id/7c(procps-ng, util-linux), /usr/lib/.build-id/95(coreutils, xfsprogs, libsss_nss_idmap, libsolv, deltarpm), /usr/lib/.build-id/25 (perl-Unicode-Normalize, systemd, libpwquality, fuse-sshfs, gettext, kpartx, trousers, python2-lxml, openssl-libs), /usr/lib/.build- id/16(audit, glibc, gnupg2, libgpg-error, shadow-utils, python3-libs, libmetalink, python2-libs, util-linux, policycoreutils), /usr/lib /.build-id/82(python3-libcomps, openssh, libfdisk, coreutils, ykpers, e2fsprogs, libevent, pam), /usr/lib/.build-id/77(libnl3, glibc, util- linux) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dino- debuginfo , dino-debugsource [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: dino-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64.rpm dino-devel-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64.rpm dino-debuginfo-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64.rpm dino-debugsource-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64.rpm dino-0.0-0.3.20190116.git.8e14ac6.fc30.src.rpm dino.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libdino.so dino.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libqlite.so dino.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libxmpp-vala.so dino.x86_64: W: no-manual-page-for-binary dino dino.x86_64: W: file-not-in-%lang /usr/share/locale/ar/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/ar/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/ar/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/ca/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/ca/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/ca/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/en/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/en/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/en/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/eo/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/eu/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/eu/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/eu/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/fi/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/gl/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/gl/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/gl/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/hu/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/hu/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/hu/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/it/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/it/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/it/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/ja/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/lb/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/lb/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/lb/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/nb/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/nb/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/nb/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/nl/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/nl/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/nl/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/nl_BE/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/nl_BE/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/nl_BE/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/pl/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/pl/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/pl/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/pt_BR/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/ro/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/ro/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/ro/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/ru/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/ru/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/ru/LC_MESSAGES/dino.mo dino.x86_64: E: incorrect-locale-subdir /usr/share/locale/zh_Hans/LC_MESSAGES/dino-omemo.mo dino.x86_64: E: invalid-lc-messages-dir /usr/share/locale/zh_Hans/LC_MESSAGES/dino-omemo.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/zh_Hans/LC_MESSAGES/dino-omemo.mo dino.x86_64: E: invalid-lc-messages-dir /usr/share/locale/zh_Hans/LC_MESSAGES/dino-openpgp.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/zh_Hans/LC_MESSAGES/dino-openpgp.mo dino.x86_64: E: invalid-lc-messages-dir /usr/share/locale/zh_Hans/LC_MESSAGES/dino.mo dino.x86_64: W: file-not-in-%lang /usr/share/locale/zh_Hans/LC_MESSAGES/dino.mo dino-devel.x86_64: W: no-documentation dino.src: W: invalid-url Source1: libsignal-protocol-c-bundle-2.3.2.tar.bz2 5 packages and 0 specfiles checked; 4 errors, 64 warnings. Rpmlint (debuginfo) ------------------- Checking: dino-debuginfo-0.0-0.3.20190116.git.8e14ac6.fc30.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- dino (rpmlib, GLIBC filtered): filesystem hicolor-icon-theme libc.so.6()(64bit) libcairo.so.2()(64bit) libdino.so.0()(64bit) libgcrypt.so.20()(64bit) libgcrypt.so.20(GCRYPT_1.6)(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgee-0.8.so.2()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgpgme.so.11()(64bit) libgpgme.so.11(GPGME_1.0)(64bit) libgpgme.so.11(GPGME_1.1)(64bit) libgtk-3.so.0()(64bit) libicuuc.so.63()(64bit) libpango-1.0.so.0()(64bit) libqlite.so.0()(64bit) libqrencode.so.3()(64bit) libsoup-2.4.so.1()(64bit) libsqlite3.so.0()(64bit) libxmpp-vala.so.0()(64bit) rtld(GNU_HASH) dino-debuginfo (rpmlib, GLIBC filtered): dino-devel (rpmlib, GLIBC filtered): dino(x86-64) dino-debugsource (rpmlib, GLIBC filtered): Provides -------- dino: application() application(im.dino.Dino.desktop) bundled(libsignal-protocol-c) bundled(protobuf-c) dino dino(x86-64) libdino.so.0()(64bit) libqlite.so.0()(64bit) libxmpp-vala.so.0()(64bit) metainfo() metainfo(im.dino.Dino.appdata.xml) mimehandler(x-scheme-handler/xmpp) dino-debuginfo: debuginfo(build-id) dino-debuginfo dino-debuginfo(x86-64) dino-devel: dino-devel dino-devel(x86-64) dino-debugsource: dino-debugsource dino-debugsource(x86-64) Unversioned so-files -------------------- dino: /usr/lib64/dino/plugins/http-files.so dino: /usr/lib64/dino/plugins/omemo.so dino: /usr/lib64/dino/plugins/openpgp.so dino: /usr/lib64/libdino.so dino: /usr/lib64/libqlite.so dino: /usr/lib64/libxmpp-vala.so Source checksums ---------------- https://github.com/dino/dino/archive/8e14ac6d714b7f88e16de31a6c795e811dc27417/dino-8e14ac6d714b7f88e16de31a6c795e811dc27417.tar.gz : CHECKSUM(SHA256) this package : c80365f9365c71eb5cab9d333e7e5043a81d7b11e4134bbfad8f97a6f0135313 CHECKSUM(SHA256) upstream package : c80365f9365c71eb5cab9d333e7e5043a81d7b11e4134bbfad8f97a6f0135313 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1674181 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
