[Bug 1674278] Review Request: tty-clock - clock using libncurses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1674278



--- Comment #10 from idf31@xxxxxxxxxxxxxx ---
(In reply to Elliott Sales de Andrade from comment #9)
> You should link to raw versions of the files so that tools like
> fedora-review work.
> 
> * Remove lib from summary
> * BuildRequires cannot use %{?_isa}
> * Requires:ncurses is unnecessary (unless your executable is not linked to
> ncurses, which would be wrong anyway)
> * %changelog doesn't follow the prescribed format

Thank you for your review.
I have removed the lib from summary
I have removed %{?_isa} from BuildRequires
I have removed Requires: ncurses
I have modified the changelog according to the prescribed format
The raw .spec is here:
https://gitlab.com/IDF31/tty-clock-spec/raw/master/tty-clock.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux