https://bugzilla.redhat.com/show_bug.cgi?id=1674522 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok TODO: perl(Test::Needs) is required only for network test. It is required only with enable "perl_LWP_ConsoleLogger_enables_network_test" $ rpm -qp --requires perl-LWP-ConsoleLogger-0.000039-1.fc30.noarch.rpm | grep -v rpmlib | sort | uniq -c 1 perl(Class::Method::Modifiers) 1 perl(Data::Printer) >= 0.36 1 perl(DateTime) 1 perl(HTML::Restrict) 1 perl(HTTP::Body) 1 perl(HTTP::CookieMonster) 1 perl(JSON::MaybeXS) >= 1.003005 1 perl(List::AllUtils) 1 perl(Log::Dispatch) >= 2.56 1 perl(LWP::ConsoleLogger) 1 perl(LWP::ConsoleLogger::Easy) 1 perl(LWP::UserAgent) 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(Module::Load::Conditional) 1 perl(Moo) 1 perl(MooX::StrictConstructor) 1 perl(Parse::MIME) 1 perl(Ref::Util) 1 perl(strict) 1 perl(String::Trim) 1 perl(Sub::Exporter) 1 perl(Term::Size::Any) 1 perl(Text::SimpleTable::AutoWidth) >= 0.09 1 perl(Try::Tiny) 1 perl(Types::Common::Numeric) 1 perl(Types::Standard) 1 perl(URI::Query) 1 perl(URI::QueryParam) 1 perl(:VERSION) >= 5.6.0 1 perl(warnings) 1 perl(XML::Simple) Binary requires are Ok. $ rpm -qp --provides perl-LWP-ConsoleLogger-0.000039-1.fc30.noarch.rpm | sort | uniq -c 1 perl(LWP::ConsoleLogger) = 0.000039 1 perl-LWP-ConsoleLogger = 0.000039-1.fc30 1 perl(LWP::ConsoleLogger::Easy) = 0.000039 1 perl(LWP::ConsoleLogger::Everywhere) = 0.000039 Binary provides are Ok. $ rpmlint ./perl-LWP-ConsoleLogger* perl-LWP-ConsoleLogger.noarch: W: spelling-error %description -l en_US ua -> ya, us, u perl-LWP-ConsoleLogger.src: W: spelling-error %description -l en_US ua -> ya, us, u 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok Please consider fixing 'TODO' item. The package looks good. Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
