https://bugzilla.redhat.com/show_bug.cgi?id=1674278 Jaroslav Prokop <jar.prokop@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jar.prokop@xxxxxxxx --- Comment #1 from Jaroslav Prokop <jar.prokop@xxxxxxxx> --- I'll do an unofficial review, just some basic points: * use macros, e.g. %{_bindir}/tty-clock and %{_mandir}/man1/ ... * I don't think rm -rf buildroot is a way to go and I think there is macro for it * Changelog is in an invalid format (or at least not missing a few things) Please take a look at the guidelines, https://docs.fedoraproject.org/en-US/packaging-guidelines/ and also take a look at Domain Specific guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/#_domain_specific_guidelines I'd also recommend running rpmlint on your spec files and rpm packages before submitting I wish you good luck and looking forward to your future work! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
