https://bugzilla.redhat.com/show_bug.cgi?id=1444518 Jared Smith <jsmith.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsmith.fedora@xxxxxxxxx Assignee|pwhalen@xxxxxxxxxx |jsmith.fedora@xxxxxxxxx Flags|fedora-review? |fedora-review+ --- Comment #8 from Jared Smith <jsmith.fedora@xxxxxxxxx> --- I have reviewed this package, and it needs a couple of minor fixups, but is otherwise APPROVED. The package follows the Fedora Packaging Guidelines, and is under a proper license. Please consider applying the following changes before pushing the package to Fedora: --- libcoap.spec.orig 2019-02-09 15:14:46.030448525 -0500 +++ libcoap.spec 2019-02-09 15:20:15.054881402 -0500 @@ -6,9 +6,9 @@ Summary: C library implementation of CoAP URL: https://libcoap.net/ # If build against gnutls the license is BSD + LGPL 2.1 -License: BSD + OpenSSL +License: BSD -Source0: https://github.com/obgm/libcoap/archive/v%{version}.tar.gz#/%{name}-%{version}%{?candidate:-%{candidate}}.tar.gz +Source0: https://github.com/obgm/libcoap/archive/v%{version}%{?candidate:-%{candidate}}.tar.gz#/%{name}-%{version}%{?candidate:-%{candidate}}.tar.gz BuildRequires: autoconf BuildRequires: automake @@ -94,7 +94,7 @@ %{_libdir}/libcoap-2*.so %changelog -* Sat Feb 9 2019 Peter Robinson <pbrobinson@xxxxxxxxxxxxxxxxx> 4.2.0-0.1-rc4 +* Sat Feb 9 2019 Peter Robinson <pbrobinson@xxxxxxxxxxxxxxxxx> 4.2.0-0.1.rc4 - Update to 4.2.0 rc4 * Sat Jul 1 2017 Peter Robinson <pbrobinson@xxxxxxxxxxxxxxxxx> 4.1.2-2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
