https://bugzilla.redhat.com/show_bug.cgi?id=1301270 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Don't think this is valid. It's only used for alternate name or rename. Provides: MTA - Not needed: %{__rm} -rf ${RPM_BUILD_ROOT} - Not needed: %defattr(-,root,root) - %{__make} %{?_smp_mflags} → %make_build - %{__make} install DESTDIR=${RPM_BUILD_ROOT} → %make_install - Source0: https://github.com/corecode/dma/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz → Source0: %url/archive/v%{version}/%{name}-%{version}.tar.gz - %{__install} -m 644 → install -p -m 644 - The license file mist be installed with %license' not %doc: %license LICENSE %doc README.* TODO - Version 0.11 was published, why aren't you using it? - Add gcc as a BR - Use %set_build_flags at the start of the build to use Fedora build flags: %build %set_build_flags - capitalize the summary -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
