https://bugzilla.redhat.com/show_bug.cgi?id=1672994 --- Comment #4 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to Elliott Sales de Andrade from comment #2) > This is mostly good; a few minor issues: > > - You have COPYING doubly listed in %doc and %license. Done. > - Should add the soversion to the %files to prevent unintentional soname > breaks. Neat trick! Will do the same in some my other packages. Done. > - BuildRequires:pkgconfig is unnecessary since you already require some > pkgconfig files. Done. > - Use %make_build. Done. > - There is something wrong with the linking of the shared library. It uses > GTK > and GObject symbols, but it not linked to them. Consequently, the main rpm > does not depend on either. > ... > > [!]: Final provides and requires are sane (see attachments). I'll look into this. Hold on. > [!]: %check is present and all tests pass. Added a check section. Just in case upstream adds tests in a future. (In reply to Elliott Sales de Andrade from comment #3) > Also, the pc.in file should not be executable; there's a warning about this > during the build and it's automatically corrected. Done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
