[Bug 1670441] Review Request: setconf - Tool for changing values of parameters in text files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1670441

Petr Viktorin <pviktori@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pviktori@xxxxxxxxxx



--- Comment #17 from Petr Viktorin <pviktori@xxxxxxxxxx> ---
%{_bindir}/setconf is a tool that can be called directly.
%{python3_sitelib}/setconf.py is a Python library. If necessary it can be
called as `python3 -m setconf`, and shouldn't have a shebang.

The test is unfortunately testing the source, which doesn't match how this
should be installed in a distro. For a system-installed package, "/usr/bin/env
python" is the wrong shebang anyway (system tools shouldn't depend on the
current $PATH).
So, for RPM the test could have all "../setconf.py" changed to "%{__python3}
../setconf.py".
The upstream might accept a commit that changes these to "$PYTHON
../setconf.py" (with $PYTHON defaulting to just "python").

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux