https://bugzilla.redhat.com/show_bug.cgi?id=1672896 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are almost ok FIX: Please add BR 'make', it is used in spec file. $ rpm -qp --requires perl-Applify-0.15-1.fc30.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(constant) 1 perl(File::Basename) 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Please add run-require 'perl(Getopt::Long)' - lib/Applify.pm:346 $ rpm -qp --provides perl-Applify-0.15-1.fc30.noarch.rpm | sort | uniq -c 1 perl(Applify) = 0.15 1 perl-Applify = 0.15-1.fc30 Binary provides are Ok. $ rpmlint ./perl-Applify* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok Please correct all 'FIX' issues. Otherwise the package looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
