https://bugzilla.redhat.com/show_bug.cgi?id=1658153 --- Comment #22 from J. Scheurich <mufti11@xxxxxx> --- 2. Why "Requires: kolourpaint" and not, say, gimp? $ cat wdune*/README_LINUX.txt ... ====================================== Why not gimp as default image editor ? ====================================== gimp is a good image editor, but it is not a good tool for commandline. When you use e.g. "gimp test.png" on the commandline, modify the image and use File->Save, it doesn't write back the file. In fact you can use File->Export instead of File->Save, but this is confusiong 8-( so the default uses a other image editor like pinta. If you need to use gimp, simply replace the image editor setting $ The image editor setting is in options in the GUI... 3. Why "Requires: lxterminal"? That's wrong for users who are not using LXDE. lxterminal is a usual X client, that runs everwhere, not only under LXDE. Ir is rhe only xterm clone, that keeps the font setting. In the xterm commanline you need to set the font size, the default is too small. If you don't want lxterminal, you can change this in options in the GUI 4. Add "Requires: coreutils" since the code invokes cat, echo, ls, mkdir, etc. It's probably silly, since who could have a system with no coreutils? Nevertheless, humor me. 5. Likewise, add "Requires: grep", since I see grep being invoked as well. The runtime do not invoke cat grep etc. so coreutils and grep are a BuildRequires, i will fix that 7. There are a lot of licenses in this code. I'm not confident that GPLv3+ is an accurate summation of them. In short. there are 5 types of licenses in the code - GPL2 - GPL3 - MIT - LGPL - permisson ro copy and modify GPL3 is the summation of it or what should i use instead of it ? If you declare a permisson ro copy and modify license as GPL3, this is legal, GPL3 only adds restrictions. 8. The code in vcglib/eigenlib looks like a bundled copy of eigen3. Please check whether it is or not. If it is, it needs to be unbundled. It lloks like vcglib includes some files of eigen3, but there are more (header) files. I have big problems to find a sponsor for wdune, it would make the task much more difficult to get a sposor for vcglib 8-( So i added vcglib which is only a bunch of include headers, not a real library. white_dune still compiles without vcglib, but the imprtant feature "mesh reducer" would not be available 8-( I have the choice to remove vcgib or not 8-( -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
