[Bug 1670656] Review Request: grafana - an open source, feature rich metrics dashboard and graph editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1670656



--- Comment #11 from Xavier Bachelot <xavier@xxxxxxxxxxxx> ---
(In reply to Mark Goodwin from comment #10)
> > # license and other package docs, but not APP docs (they're online)
> > install -p -m 644 LICENSE.md %{buildroot}/%{_defaultlicensedir}/%name
> > install -p -m 644 README.md ROADMAP.md CHANGELOG.md PLUGIN_DEV.md %{buildroot}/%{_docdir}/%{name}
> > install -p -m 644 CODE_OF_CONDUCT.md CONTRIBUTING.md NOTICE.md %{buildroot}/%{_docdir}/%{name}
> > then in %files :
> > # other docs and license
> > %doc %{_datadir}/doc/%{name}
> > %license %{_defaultlicensedir}/%name/LICENSE.md
> > 
> > --> Just use the following in %files, the %doc and %license macro take care of installing the files in the proper location :
> > %license LICENSE.md
> > %doc CHANGELOG.md CODE_OF_CONDUCT.md CONTRIBUTING.md NOTICE.md
> > %doc PLUGIN_DEV.md README.md ROADMAP.md UPGRADING_DEPENDENCIES.md
> 
> The %doc macro isn't finding those files correctly when they're named
> individually
> - it cd's to the wrong directory.  So I've left this as-is for now, as
> follows
> 
> %doc %{_datadir}/doc/%{name}
> %license %{_defaultlicensedir}/%name/LICENSE.md
> 
Ok, got it. That comes from the way the %prep step is done. Look at the
attached patched for a simplified approach.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux