[Bug 1670441] Review Request: setconf - Tool for changing values of parameters in text files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1670441



--- Comment #5 from Patrik Kopkan <pkopkan@xxxxxxxxxx> ---
(In reply to Miro Hrončok from comment #3)
> Any conclusion? Also note that FedoaReview is automated (and quite broken)
> tool. You are doing the review, not the tool. You should not paste stuff
> like:
> 
>     Cannot parse rpmlint output
> 
> But instead, you should run that check manually or decide is not worth it
> and remove that section.
> 
> The same goes for the rpmlint output that actually happened here. Any
> comments on the errors?
> 
> ---------
> 
> Spec sanity check by me:
> 
> 1) %files -n %{name} -> just %files
> 
> 2) %{python3_sitelib}/__pycache__/%{name}.*.py* -> do you except any file
> extensions other than pyc here?
> 
> 3) %{python3_sitelib}/%{name}-%{version}-py%{python3_version}.egg-info -> is
> this a directory? if so, use a trailing slash to make sure it stays that way
> 
> 4)
> https://github.com/xyproto/%{name}/archive/%{version}.tar.gz#/%{name}-
> %{version}.tar.gz ->
> https://github.com/xyproto/%{name}/archive/%{version}/%{name}-%{version}.tar.
> gz

Sry, you was too quick for me and thanks I missed theese thinks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux