Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation https://bugzilla.redhat.com/show_bug.cgi?id=253588 ------- Additional Comments From michel.sylvan@xxxxxxxxx 2007-09-21 18:55 EST ------- Here's the initial review. Most things are fine, with apart from the problems noted below. I've built it on my Rawhide x86_64 box a few days ago, but currently it does not build in mock: - F7 does not have ocaml-findlib{,-devel}: http://koji.fedoraproject.org/koji/taskinfo?taskID=169938 Building against Rawhide on Koji failed mysteriously, trying against dist-f8 now, but it looked like a build server problem anyway. Documentation should probably be split into -doc, as it pertains the use of cilly as well, and introduces the infrastructure in general. Your call. Oh, and perl(CilConfig) should provide a version number! MUST FAILED: • clean buildroot before install: no • rpmlint ocaml-cil.src:66: W: unversioned-explicit-provides perl(CilConfig) • build dependencies complete: : can't build on FC7, no ocaml-findlib* • -doc: might want to create separate -doc, since it also contains documentation on cilly PASSED: • package name: hmm. it produces a tool that is useful for programming in C, so in a way it's an application written in OCaml, but to customize it you need to write in OCaml, so it's an OCaml lib. probably OK as it is • spec file name: matches • package guideline-compliant: yes • license complies with guidelines: yes • license field accurate: yes • license file not deleted: yes • spec in US English: yes • spec legible: yes • source matches upstream: yes • builds under >= 1 archs, others excluded • own all directories: yes • no dupes in %files: yes • permission: yes • %clean must clean RPM_BUILD_ROOT: yes • macros used consistently: yes • must contain code: yes • headers in -devel: yes • devel must require versioned base package: yes • filenames UTF-8 SHOULD FAILED: • package build in mock on all architectures PASSED: • package functioned as described: yes • scriplets are sane: yes • other subpackages should require versioned base: yes • require package, not files: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review