https://bugzilla.redhat.com/show_bug.cgi?id=1672047 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Looks pretty good, but a few issues with bundling and enabling features. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - It bundles a lot more things, and I expect we should be able to unbundle a majority of them that are fortunately already in Fedora: * Boost (in Fedora) * Eigen (in Fedora) * zlib (in Fedora) * SFMT (not in Fedora, but looks simple to package) - Do the Vcell etc features require Vcell to be packaged already? If not, that can be enabled. Vcell is on our list, but it's a web app: https://pagure.io/neuro-sig/NeuroFedora/issue/213 - VTK support can be enabled. It's in Fedora. - PDE support can be enabled. I can't find a PDE software, but here's Kairos which also includes the same Io.cpp and Io.h files that this does: https://github.com/martinjrobins/Kairos/tree/master/src I wonder if they've been bundled there too. (It's only two files, so bundling them isn't too bad) - Shouldn't the main package also contain a versioned soname that the binary will use? Is smoldyn meant to be used as a library---otherwise the devel package is not needed either. - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 91258880 bytes in 1812 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ^ All the docs including the examples can go in the docs package. Otherwise the devel package becomes very large. - Please do not include a license file if upstream has not provided it. We should file a bug upstream asking them to do include it. - Cosmetic issue: could we have all the BRs on individual lines please? It makes it easier for scripts to work with spec files etc. - Please fix rpmlint issues: smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S2_config/macformat.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S2_config/windowsformat.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S94_archive/Andrews_2018/note2_transposase/transposase.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S94_archive/Andrews_2018/note4_MinD/MinDdimer.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/bimolecularlattice.txt smoldyn-devel.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S95_regression/bimolecularlattice.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_b.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_b_nb.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_e.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_e_nb.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_n.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_n_nb.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_t.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_t_nb.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/stick.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/surfacediffuse.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S96_bugs/AC1_calcium_lattice.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S98_utilityprograms/wrl2smol/sample-surface.wrl smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S99_more/Min/Min4.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S99_more/Min/Min5.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S99_more/antigen/antigen.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S99_more/li.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S99_more/microtubule_cata_13_sync_die.txt smoldyn-devel.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S99_more/microtubule_cata_13_sync_die.txt smoldyn-doc.noarch: W: spurious-executable-perm /usr/share/doc/smoldyn-doc/BioNetGen/Faeder_Hlavacek_2009.pdf ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Public domain", "Mozilla Public License (v2.0) GNU Lesser General Public License", "Unknown or generated", "Mozilla Public License (v2.0) GNU Lesser General Public License (v2.1 or later)", "NTP License BSL (v1.0)", "BSD 3-clause "New" or "Revised" License", "Mozilla Public License (v2.0) GNU Lesser General Public License (modified-code-notice clause) GNU Lesser General Public License (v2.1 or later)", "zlib/libpng license", "BSL (v1.0)", "GNU Lesser General Public License (v3 or later)", "Mozilla Public License (v2.0)". 2554 files have unknown license. Detailed output of licensecheck in /home/asinha/dump/fedora-reviews/1672047-smoldyn/licensecheck.txt Unbunding would simplify the licenses too. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. (Note snipped) [!]: %build honors applicable compiler flags or justifies otherwise. Looks like upstream also sets flags in CMakeLists.txt and these get added to the list. Please remove them so that only our Fedora flags are used. [!]: Package contains no bundled libraries without FPC exception. Please see notes on bundling. [!]: Changelog in prescribed format. Please update the changelog. I think it's from another package :) [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. ^ Please remove SOURCE1. If upstream does not include a license file, we should't add one ourselves. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: smoldyn-devel. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in smoldyn- devel , smoldyn-doc , smoldyn-debuginfo , smoldyn-debugsource ^ False positive here. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 93040640 bytes in /usr/share smoldyn-devel-2.56-1.fc30.x86_64.rpm:93020160 See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: smoldyn-2.56-1.fc30.x86_64.rpm smoldyn-devel-2.56-1.fc30.x86_64.rpm smoldyn-doc-2.56-1.fc30.noarch.rpm smoldyn-debuginfo-2.56-1.fc30.x86_64.rpm smoldyn-debugsource-2.56-1.fc30.x86_64.rpm smoldyn-2.56-1.fc30.src.rpm smoldyn.x86_64: W: spelling-error %description -l en_US stochasticity -> stochastic, chastity smoldyn.x86_64: W: spelling-error %description -l en_US nanometer -> manometer, anemometer, anteroom smoldyn.x86_64: W: incoherent-version-in-changelog 5.0-0.1.beta ['2.56-1.fc30', '2.56-1'] ^ Pointed out above already smoldyn.x86_64: W: no-documentation smoldyn.x86_64: W: no-manual-page-for-binary smoldyn smoldyn-devel.x86_64: W: summary-not-capitalized C smoldyn devel files smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S2_config/macformat.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S2_config/windowsformat.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S94_archive/Andrews_2018/note2_transposase/transposase.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S94_archive/Andrews_2018/note4_MinD/MinDdimer.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/bimolecularlattice.txt smoldyn-devel.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S95_regression/bimolecularlattice.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_b.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_b_nb.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_e.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_e_nb.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_n.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_n_nb.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_t.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/profile3_t_nb.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/stick.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S95_regression/surfacediffuse.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S96_bugs/AC1_calcium_lattice.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S98_utilityprograms/wrl2smol/sample-surface.wrl smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S99_more/Min/Min4.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S99_more/Min/Min5.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S99_more/antigen/antigen.txt smoldyn-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S99_more/li.txt smoldyn-devel.x86_64: W: spurious-executable-perm /usr/share/doc/smoldyn-devel/examples/S99_more/microtubule_cata_13_sync_die.txt smoldyn-devel.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/smoldyn-devel/examples/S99_more/microtubule_cata_13_sync_die.txt smoldyn-doc.noarch: W: summary-not-capitalized C smoldyn PDF documentation smoldyn-doc.noarch: W: spurious-executable-perm /usr/share/doc/smoldyn-doc/BioNetGen/Faeder_Hlavacek_2009.pdf smoldyn.src: W: spelling-error %description -l en_US stochasticity -> stochastic, chastity smoldyn.src: W: spelling-error %description -l en_US nanometer -> manometer, anemometer, anteroom 6 packages and 0 specfiles checked; 2 errors, 32 warnings. Rpmlint (debuginfo) ------------------- Checking: smoldyn-debuginfo-2.56-1.fc30.x86_64.rpm smoldyn-devel-debuginfo-2.56-1.fc30.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- smoldyn (rpmlib, GLIBC filtered): libGL.so.1()(64bit) libGLU.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libglut.so.3()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtiff.so.5()(64bit) libtiff.so.5(LIBTIFF_4.0)(64bit) rtld(GNU_HASH) smoldyn-devel (rpmlib, GLIBC filtered): libGL.so.1()(64bit) libGLU.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libglut.so.3()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtiff.so.5()(64bit) libtiff.so.5(LIBTIFF_4.0)(64bit) rtld(GNU_HASH) smoldyn(x86-64) smoldyn-debugsource (rpmlib, GLIBC filtered): smoldyn-doc (rpmlib, GLIBC filtered): smoldyn smoldyn-debuginfo (rpmlib, GLIBC filtered): Provides -------- smoldyn: smoldyn smoldyn(x86-64) smoldyn-devel: libsmoldyn_shared.so()(64bit) smoldyn-devel smoldyn-devel(x86-64) smoldyn-static smoldyn-debugsource: smoldyn-debugsource smoldyn-debugsource(x86-64) smoldyn-doc: smoldyn-doc smoldyn-debuginfo: debuginfo(build-id) smoldyn-debuginfo smoldyn-debuginfo(x86-64) Source checksums ---------------- http://www.smoldyn.org/smoldyn-2.56.tgz : CHECKSUM(SHA256) this package : 755e7e7ec17e3d330f7dabb5ae7da14ba7ab29745fb5db1640caf232fb5c8da6 CHECKSUM(SHA256) upstream package : 755e7e7ec17e3d330f7dabb5ae7da14ba7ab29745fb5db1640caf232fb5c8da6 http://www.gnu.org/licenses/lgpl-3.0.txt : CHECKSUM(SHA256) this package : e3a994d82e644b03a792a930f574002658412f62407f5fee083f2555c5f23118 CHECKSUM(SHA256) upstream package : e3a994d82e644b03a792a930f574002658412f62407f5fee083f2555c5f23118 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1672047 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
